[MIRROR] Hydrotray consumes nutrients disregarding the mixture contents #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts [MDB IGNORE] (#25101) * Hydrotray consumes nutrients disregarding the mixture contents (#79794) ## About The Pull Request Hydrotrays were using `remove_any` which led to weird behaviour when you mix fertilizers. It could randomly select which reagents to consume from the hydrotray, and which reagents should stay unotuched. With `remove_all`, the plant now simply consumes a unit of the mixture, disregarding the contents. ## Why It's Good For The Game This simple fix unlocks an entire new level of gameplay for botany, as you can make mixtures that work consistently. ## Changelog :cl: fix: Hydrotrays consume nutrients according to their proportion in the mix, instead of randomly picking reagents to consume every cycle. /:cl: * Hydrotray consumes nutrients disregarding the mixture contents --------- Co-authored-by: Andrew <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 31, 2024
…on to alternate_byond_versions (#703) * Bumps min compiler version to 1621 / adds min compiler version to alternate_byond_versions (#81183) ## About The Pull Request Min compiler version is something we should probably test to make sure it actually works. Case in point: Our current min version (1609) cannot compile as of #81152 due to a byond bug fixed in version 515.1621. * Bumps min compiler version to 1621 / adds min compiler version to alternate_byond_versions --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25101
Original PR: tgstation/tgstation#79794
About The Pull Request
Hydrotrays were using
remove_anywhich led to weird behaviour when you mix fertilizers.It could randomly select which reagents to consume from the hydrotray, and which reagents should stay unotuched.
With
remove_all, the plant now simply consumes a unit of the mixture, disregarding the contents.Why It's Good For The Game
This simple fix unlocks an entire new level of gameplay for botany, as you can make mixtures that work consistently.
Changelog
🆑 MTandi
fix: Hydrotrays consume nutrients according to their proportion in the mix, instead of randomly picking reagents to consume every cycle.
/:cl: