[MIRROR] Hardcore random will not assign incompatible quirks. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NORE] (#25111) * Hardcore random will not assign incompatible quirks. (#79825) ## About The Pull Request Fixes #78114. Fixes #78505. Grumble grumble, code rot. #77727 inadvertently broke hardcore random quirk selection, making it not actually check the compatibility of quirks before adding them. This means that quirks that were never meant to go together could be randomly assigned, which broke all kinds of things. I've simply made it properly check for the typepath rather than checking typepaths against names, making it actually function as intended. ## Why It's Good For The Game Certain quirks are incompatible for a reason. Prevents unintended combos that break in unexpected ways. ## Changelog :cl: fix: Hardcore Random will no longer assign incompatible quirks. /:cl: * Hardcore random will not assign incompatible quirks. --------- Co-authored-by: lizardqueenlexi <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 19, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Fix Ore Vent's well being on improper plane (#81181) ## About The Pull Request Removed explicit plane set to `GAME_PLANE` and `ABOVE_MOB_LAYER` thus fixing issue when well was drawn on improper plane, possibly the ghost one. ## Why It's Good For The Game This PR fixes a visual bug.  ## Changelog :cl: fix: fixed ore vent's well being drawn over ash storm. /:cl: * Fix Ore Vent's well being on improper plane --------- Co-authored-by: Interception&? <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Fix Ore Vent's well being on improper plane (#81181) ## About The Pull Request Removed explicit plane set to `GAME_PLANE` and `ABOVE_MOB_LAYER` thus fixing issue when well was drawn on improper plane, possibly the ghost one. ## Why It's Good For The Game This PR fixes a visual bug.  ## Changelog :cl: fix: fixed ore vent's well being drawn over ash storm. /:cl: * Fix Ore Vent's well being on improper plane --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Interception&? <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25111
Original PR: tgstation/tgstation#79825
About The Pull Request
Fixes #78114.
Fixes #78505.
Grumble grumble, code rot.
#77727 inadvertently broke hardcore random quirk selection, making it not actually check the compatibility of quirks before adding them. This means that quirks that were never meant to go together could be randomly assigned, which broke all kinds of things. I've simply made it properly check for the typepath rather than checking typepaths against names, making it actually function as intended.
Why It's Good For The Game
Certain quirks are incompatible for a reason. Prevents unintended combos that break in unexpected ways.
Changelog
🆑 lizardqueenlexi
fix: Hardcore Random will no longer assign incompatible quirks.
/:cl: