[MIRROR] Splits placeontop proc #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits placeontop proc (#79702) ## About The Pull Request I find the proc hard to read honestly. There's no reason we can't split this into two functions - the secondary functionality is used only once, in reader.dmm. ## Why It's Good For The Game Code improvement Glorious snake case ## Changelog N/A nothing player facing --------- Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> * Splits placeontop proc * Update brass_spreader.dm --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> Co-authored-by: Bloop <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jan 31, 2024
…al list (#715) * Station Goals are now handled by SSstation instead of a global list (#81177) ## About The Pull Request You can now get station goals in a slightly better way over using a `locate() in` call on a global list. The Meteor Satellite goal no longer stores a giant list of ALL OBJECTS in view. And now correctly only counts turfs. ## Changelog :cl: fix: Meteor Satellites no longer erroneously count every piece of paper as a protected turf. fix: As a result the station goal is slightly more difficult /:cl: --------- Co-authored-by: LemonInTheDark <[email protected]> * Station Goals are now handled by SSstation instead of a global list * Modular * Okay, length() it is * Wait that was wrong before * Some more forgotten things * ... --------- Co-authored-by: Zephyr <[email protected]> Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: Mal <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 6, 2024
…al list (#715) (#1781) * Station Goals are now handled by SSstation instead of a global list (#81177) ## About The Pull Request You can now get station goals in a slightly better way over using a `locate() in` call on a global list. The Meteor Satellite goal no longer stores a giant list of ALL OBJECTS in view. And now correctly only counts turfs. ## Changelog :cl: fix: Meteor Satellites no longer erroneously count every piece of paper as a protected turf. fix: As a result the station goal is slightly more difficult /:cl: --------- * Station Goals are now handled by SSstation instead of a global list * Modular * Okay, length() it is * Wait that was wrong before * Some more forgotten things * ... --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Zephyr <[email protected]> Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25103
Original PR: tgstation/tgstation#79702
About The Pull Request
I find the proc hard to read honestly. There's no reason we can't split this into two functions - the secondary functionality is used only once, in reader.dmm.
Why It's Good For The Game
Code improvement
Glorious snake case
Changelog
N/A nothing player facing