[MIRROR] Splits reagent metabolization from reagent effects. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ORE] (#25125) * Splits reagent metabolization from reagent effects. * Update alcohol_reagents.dm --------- Co-authored-by: Ghom <[email protected]> Co-authored-by: Giz <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 20, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Exosuit-mounted RCD now works like the handheld version (#81162) ## About The Pull Request This gives the mounted RCD the same functionality as the handheld version, from upgrades to destruction scanning. Upgrades can be installed by using them on either the mech or the equipment item, and both the scanner and RCD menu can be accessed in the equipment's menu. Because mechs don't have different left/right click actions, deconstructing is toggled in the menu as well.  ## Why It's Good For The Game Gives exosuits more things to do that aren't combat-related, which I feel is lacking currently. ## Changelog :cl: add: Exosuit-mounted RCDs now have the same functionality as the handheld version. /:cl: * Exosuit-mounted RCD now works like the handheld version --------- Co-authored-by: SapphicOverload <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25125
Original PR: tgstation/tgstation#79314
About The Pull Request
I've separated the instructions responsible for gradually removing reagents from a living holder from the main
on_mob_lifeandon_mob_deadprocs, and made sure they're run after them.I've done a fair bit of early returns as well.
Why It's Good For The Game
The problem here is that most reagents will eventually be deleted before
on_mob_lifeandon_mob_deadhave finished running, since the statements that handle the reagent removal are found within parent calls that are often called at the start of the different definitions of the proc . To make it easier to understand, here's a simplified chain of events:holder.metabolize_reagent -> the parent call of reagent.on_mob_life -> holder.remove_reagent -> holder.update_total -> reagent.on_mob_end_metabolizate -> reagent.on_mob_delete -> qdel(reagent) -> the actual reagent.on_mob_life
Basically, the reagent is getting deleted before it has finished "ticking", and that's bad, simple as that.
Also, by separating these instructions from the rest, we won't have to enforce any such nuisance as
return ..() || need_mob_update.TL;DR: This fixes #79267.
Changelog
🆑 Ghommie
fix: Fixed the infinite growth serum exploit.
fix: Fixed generic nutriment processing even when dead.
/:cl: