[MIRROR] Reworks transformation sting to be temporarily in living mobs, forever in dead mobs #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, forever in dead mobs [MDB IGNORE] (#24002) * Reworks transformation sting to be temporarily in living mobs, forever in dead mobs * Modular updates * Recaches the icons generated in the `changeling` unit test * Pain * More tweaks * Disable unit test * Let's see if we can pass test temporarily * Makes transformation sting unobtainable more cleanly * Unit test * Cursed proc * Kill the unholy copy pasta Seriously this stuff is just awful. This is not maintainable. * test this * Update comments * Fixing the screenshot test, maybe? * grrr * Update changeling.dm * Attempt to fix this nonsense * Update changeling.dm * Update changeling.dm * Update changeling.dm * Update dna.dm * Fixes it? * Screenshot test * Update _traits.dm * Update _traits.dm * Fix this * Update dna.dm * Update dna.dm * Hmm * This proc needs a new name * I want to scream but I have no mutant parts * Fix * Update species.dm * Update species.dm * Update species.dm * Update species.dm * Some touch ups --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Giz <[email protected]> Co-authored-by: Jolly <[email protected]>
|
Даже если проверка пройдёт галочками - не мержить, я не тестил локально |
AnywayFarus
added a commit
that referenced
this pull request
Nov 23, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Refit Wetsuit * restricts regular shoredress * Tail Fixy * Tail Fixy FOR REAL * goodbye examine hello examine more * Update modular_nova/modules/modular_items/code/wetsuit.dm Co-authored-by: Bloop <[email protected]> * Update modular_nova/modules/modular_items/code/wetsuit.dm Co-authored-by: Bloop <[email protected]> --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24002
Original PR: tgstation/tgstation#78502
About The Pull Request
Reworks transformation sting.
Removes TRAIT_NO_TRANSFORMATION_STING, instead just checks for TRAIT_NO_DNA_COPY
Organizes some trait lists alphabetically
Adds TRAIT_STASIS, to allow for reacting to mobs entering and exiting stasis via COMSIGS
Why It's Good For The Game
A lot of people don't like the current iteration of Transformation Sting, me included
Right now it's only use is for a meme - you make the entire station into felinids until you get lynched, and that's it.
It's not really a healthy ability for ling's current kit, so this pr attempts to soft rework it to make it a bit more in line with how ling should be acting - turning it into a source of short term confusion between people, or using it on a body to cover your tracks.
This accomplish it two fold - One, it is now cheap enough to use twice in rapid succession, allowing for quick on-the-spot "BE CONFUSED" situations while you abscond. Two, as mentioned in the last paragraph, you can poke a body of someone you murder to obfuscate the crime scene and maybe help out in taking over someone's identity.
Changelog
🆑 Melbert
balance: Transformation sting now lasts 8 minutes, down from permanent. However, the effect is paused for dead and stasis mobs, making it permanent SO LONG AS they stay dead or in stasis. The effect is also permanent if used on a monkey.
balance: Transformation sting now costs 33 chemicals, down from 50.
balance: Transformation sting now costs 2 dna points, down from 3.
fix: Transformation sting works on monkeys again.
refactor: Refactored a bit of human randomization.
/:cl: