Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] PRs with the "Good First PR" label now award 6 GBPs #798

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25218
Original PR: tgstation/tgstation#79874

About The Pull Request

Exactly what it reads on the tin.

Why It's Good For The Game

I've brought it up with the maintainers, and Oranges said it should award the same amount of a feature so first-time contributors don't get overly penalized by it.

Changelog

N/A

…ORE] (#25218)

* PRs with the "Good First PR" label now award 6 GBPs (#79874)

## About The Pull Request
Exactly what it reads on the tin.

## Why It's Good For The Game
I've brought it up with the maintainers, and Oranges said it should
award the same amount of a feature so first-time contributors don't get
overly penalized by it.

## Changelog
N/A

* PRs with the "Good First PR" label now award 6 GBPs

---------

Co-authored-by: Ghom <[email protected]>
@Iajret Iajret merged commit b38fa13 into master Nov 24, 2023
23 of 24 checks passed
@Iajret Iajret deleted the upstream-mirror-25218 branch November 24, 2023 09:56
Iajret pushed a commit that referenced this pull request Feb 7, 2024
* Mechs now use proper name when renamed (#81309)

## About The Pull Request

When you rename a mech, it now becomes a proper name.

## Why It's Good For The Game

People give their guns people names, and in my experience people also
give mechs people names, it would be cool if they were referred to
'thing' instead of 'the thing', to encourage that.

## Changelog

:cl:
spellcheck: Mechs that have been renamed now are proper names, so are
not described as 'the' mech.
/:cl:

* Mechs now use proper name when renamed

---------

Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants