Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Deprecates hud_trait where possible, introduces lists where not #802

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25204

About The Pull Request

Adds list support to all nif hud traits and prepares us for the removal of hud traits in general (see tgstation/tgstation#79891), cutting maintainer work by about 5 minutes

How This Contributes To The Skyrat Roleplay Experience

The projector huds are no longer inferior to regular huds and show all the important information

Proof of Testing

Screenshots/Videos

See this one and only screenshot from the testing session:
image
(Notice the retinal projector together with the status readout from it)

Changelog

🆑 Majkl-J
fix: Projector hud traits now get applied correctly
refactor: hud_trait gets deprecated, using clothing_traits instead
/:cl:

* screaming

* woop woop

* Update hud.dm

* Update modular_skyrat/modules/modular_items/code/modular_glasses.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Skyrat Mirror Fix Refactoring labels Nov 23, 2023
@Iajret Iajret merged commit 76bc98d into master Nov 24, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25204 branch November 24, 2023 21:28
AnywayFarus added a commit that referenced this pull request Nov 24, 2023
Iajret pushed a commit that referenced this pull request Feb 9, 2024
* Better Ghost Hair

* Update observer.dm

---------

Co-authored-by: LemonInTheDark <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
Co-authored-by: Mal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants