Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes tgui dev server #806

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[MIRROR] Fixes tgui dev server #806

merged 1 commit into from
Nov 24, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25226
Original PR: tgstation/tgstation#79898

About The Pull Request

  • the .js extensions were required, this is my fault.
  • fixes a crash "automatic publicPath is not supported in this browser"

Why It's Good For The Game

Bug fixes. Dev server is working

Changelog

N/A nothing player facing

* Fixes tgui dev server [NO GBP] (#79898)

## About The Pull Request
- the .js extensions were required, this is my fault.
- fixes a crash "automatic publicPath is not supported in this browser"
## Why It's Good For The Game
Bug fixes. Dev server is working
## Changelog
N/A nothing player facing

* Fixes tgui dev server [NO GBP]

---------

Co-authored-by: Jeremiah <[email protected]>
@Iajret Iajret merged commit 70f7cbe into master Nov 24, 2023
23 of 24 checks passed
@Iajret Iajret deleted the upstream-mirror-25226 branch November 24, 2023 09:57
Iajret pushed a commit that referenced this pull request Feb 8, 2024
* Makes point_types not be dumb

* Makes point_types not be dumb (#81202)

## About The Pull Request

We currently have a list of point types that is meant to be
list(``DEFINE`` = name) but it's completely useless since the define is
just the name anyways. It's not used for anything, it has no purpose to
be this way. It seems more like a holdover from when there were multiple
types of research points (it was made for that purpose, even before
nanite points were a thing) but even for that, it serves no purpose.

I reworked it now to be the abbreviated name of the research point type,
de-hardcoding techwebs a little bit and removing the need for
downstreams to edit the techweb UI.

## Why It's Good For The Game

This at least looks better and makes more sense at people just looking
over it.

## Changelog

No player-facing changes.

---------

Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants