[MIRROR] Bitrunning glitches that don't escape their domain don't show up in the roundend report #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w up in the roundend report [MDB IGNORE] (#25244) * Bitrunning glitches that don't escape their domain don't show up in the roundend report (#79910) ## About The Pull Request Exactly what the title says. I was planning to fully refactor glitches to function more like lavaland elites, which they operate more similarly to, but I was lazy and also discovered the `show_in_roundend` var on `/datum/antagonist` - setting that to `FALSE` does the thing I cared most about. Making them still appear in the roundend report if they escape was Fikou's idea. ## Why It's Good For The Game Does the roundend report really need to list a hostile that will cease to exist soon after killing the only characters it can interact with? ## Changelog :cl: qol: Bitrunning glitches will not show up in the roundend report unless they escape the virtual domain. /:cl: * Bitrunning glitches that don't escape their domain don't show up in the roundend report --------- Co-authored-by: Y0SH1M4S73R <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 25, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Reactions now use volume averaged purity (#81246) ## About The Pull Request Cause it only makes sense Currently the purity of reagents created in a reaction is computed as follows `total sum of purity of all reagents present / total number of reagents` This is incorrect because regardless of how much "volume" of an impure/pure reagent is present the purity of the final solution is unaffected. Logically if we have more amount of an impure reagent the more impure the final solution should be & same for opposite case. This is the case for ph, where if we have a large volume of say "acidic" reagent then changes in other reagents have a small effect to the overall "acidity" of the solution. The same concept now applies for purity as well `get_average_purity()`accounts for volume thus yielding more realistic results. The effect becomes more significant with larger volumes of reagents. :cl: fix: reactions now compute purity of reagents based on their volume, meaning larger amounts of reagents created will have more significant effects on the final purity of the solution /:cl: * Reactions now use volume averaged purity * Merge #818 --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25244
Original PR: tgstation/tgstation#79910
About The Pull Request
Exactly what the title says. I was planning to fully refactor glitches to function more like lavaland elites, which they operate more similarly to, but I was lazy and also discovered the
show_in_roundendvar on/datum/antagonist- setting that toFALSEdoes the thing I cared most about.Making them still appear in the roundend report if they escape was Fikou's idea.
Why It's Good For The Game
Does the roundend report really need to list a hostile that will cease to exist soon after killing the only characters it can interact with?
Changelog
🆑 Y0SH1M4S73R
qol: Bitrunning glitches will not show up in the roundend report unless they escape the virtual domain.
/:cl: