Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Allows radios to be used in mechas #825

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25238

About The Pull Request

Title.

Closes Skyrat-SS13/Skyrat-tg#25200

On a side note this edit really needs to be revisited later, this is a weird way of doing it and has, as the amount of patchwork fixes in here would show, unintended consequences

How This Contributes To The Skyrat Roleplay Experience

This seems completely unintended.

Proof of Testing

Screenshots/Videos pending

Changelog

🆑 nikothedude
fix: Radios can be used in mechs
/:cl:

@Iajret Iajret merged commit fd3d78d into master Nov 26, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25238 branch November 26, 2023 09:08
AnywayFarus added a commit that referenced this pull request Nov 26, 2023
Iajret pushed a commit that referenced this pull request Feb 7, 2024
#825)

* Tramstation Isolation cell doors actually open on their timer (#81312)

## About The Pull Request
Setting a timer in the tramstation isolation cells now actually opens
the corresponding cell door.

In addition, the door out of the isolation wing has unrestricted access
from the west.

Added a "id" var to security airlocks to accomplish this (that the
windoors already had).
## Why It's Good For The Game
A lot of security players still don't use genpop on tramstation, and
it's incredibly lame if you're given a measly 3 minute-sentence, but
security misses the radio announcement that the timer has expired and
you've had your radio confiscated. I'm assuming this was an oversight
(why were there timers in the first place if they didn't work?), but in
any event, this brings tramstation isolation brigging to parity with
other maps.

## Changelog
:cl: PapaMichael
fix: tramstation isolation cells now properly open on their timer.
/:cl:

* Tramstation Isolation cell doors actually open on their timer

---------

Co-authored-by: PapaMichael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can't use your radio while in a mech
3 participants