Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Makes the Bitrunning Den area a cargo subtype #826

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25251
Original PR: tgstation/tgstation#79907

About The Pull Request

Converts the bitrunning areas from a station area subtype to a cargo area subtype.

/area/station/bitrunning -> /area/station/cargo/bitrunning

/area/station/bitrunning/den -> /area/station/cargo/bitrunning/den

This includes an updatepaths script. Neat!

Why It's Good For The Game

It's a cargo role, and it's always located within cargo. I think it's a cargo area. Unity for all jobs under the great Cargonian umbrella!

Changelog

🆑 Rhials
code: Bitrunning/Bitrunning Den areas are now cargo area subtypes, rather than station area subtypes.
/:cl:

…#25251)

* Makes the Bitrunning Den area a cargo subtype (#79907)

## About The Pull Request

Converts the bitrunning areas from a station area subtype to a cargo
area subtype.

`/area/station/bitrunning -> /area/station/cargo/bitrunning`

`/area/station/bitrunning/den -> /area/station/cargo/bitrunning/den`

This includes an updatepaths script. Neat!
## Why It's Good For The Game

It's a cargo role, and it's always located within cargo. I think it's a
cargo area. Unity for _all_ jobs under the great Cargonian umbrella!
## Changelog
:cl: Rhials
code: Bitrunning/Bitrunning Den areas are now cargo area subtypes,
rather than station area subtypes.
/:cl:

* Makes the Bitrunning Den area a cargo subtype

* UpdatePaths

---------

Co-authored-by: Rhials <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit 902328d into master Nov 25, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25251 branch November 25, 2023 23:22
AnywayFarus added a commit that referenced this pull request Nov 25, 2023
Iajret pushed a commit that referenced this pull request Feb 7, 2024
* Fix bad reference management in object overlay circuit  (#81338)

## About The Pull Request

`/obj/item/circuit_component/object_overlay` handled the wrong
references when implementing `Destroy`.

## Changelog

:cl: Melbert
fix: The object overlay circuit component will no longer take things
with it.
/:cl:

* Fix bad reference management in object overlay circuit

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants