Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Removes unused proc from reagent holder #833

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25265
Original PR: tgstation/tgstation#79917

About The Pull Request

Found another proc that was not used anywhere

Changelog

🆑 SyncIt21
code: removes unused proc generate_possible_reactions() from reagent holder
/:cl:

* Removes unused proc from reagent holder (#79917)

## About The Pull Request
Found another proc that was not used anywhere

## Changelog
:cl:
code: removes unused proc `generate_possible_reactions()` from reagent
holder
/:cl:

* Removes unused proc from reagent holder

---------

Co-authored-by: SyncIt21 <[email protected]>
@Iajret Iajret merged commit 4df477d into master Nov 26, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25265 branch November 26, 2023 18:15
AnywayFarus added a commit that referenced this pull request Nov 26, 2023
Iajret pushed a commit that referenced this pull request Feb 8, 2024
* Fixes text effects for runechat. (#81170)

## About The Pull Request
This stuff has been cramping 100% heavy roleplay style for too long.

Somehow, the way maptext is formatted* seems to break tag ends found
around a line break. This usually happens when a space with width is
found by the end of the line, and I don't recall ever encountering the
issue otherwise.
Apparently, I've also found out that concatenating two spaces,
regardless of width, seems to fix the issue just fine, and that brings
in the solution to this whole pedantic problem: a <b>zero-width
space</b> at the end of the closing tag.

*That's handled behind the curtains by the engine, so I can only throw
wild guesses to why it happens.

Oh, by the by, I've also changed the tip about text modifiers I've made
over a year ago. It was too confusing to read.

* Fixes text effects for runechat.

---------

Co-authored-by: Ghom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants