[MIRROR] Fixes Ghostize Runtime #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes Ghostize Runtime (#79927) ## About The Pull Request  I had this runtime sitting around for who-knows-how-long so I decided I would just fix it today. `ghostize()` is expected to work on all subtypes of `/mob` so it's a bad idea to access a variable that only exists on `/mob/living` (and there is no real point to move `timeofdeath` up a level imo, we already have too much clutter there and `/mob/camera/imaginary_friend` would _never_ need it). ## Why It's Good For The Game We should only access variables like these when when they exist. ## Changelog No shot a player would ever notice this * Fixes Ghostize Runtime --------- Co-authored-by: san7890 <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Fixes to gas station ruin in icebox (#81281) ## About The Pull Request Fixes some things(check mapdiff2 for them) mainly the double terminal that probably was giving the ruin 0 power consumption i think removes the double invisible tiny fans and replaces them with double vents fixes the areas a bit removes some modifiers on the APC ## Why It's Good For The Game Fixes are good for the game ## Changelog :cl: fix: Fixed some things in Ice Box's gas station ruin add: Adds some things in Ice Box's gas station ruin /:cl: * Fixes to gas station ruin in icebox --------- Co-authored-by: EEASAS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25264
Original PR: tgstation/tgstation#79927
About The Pull Request
I had this runtime sitting around for who-knows-how-long so I decided I would just fix it today.
ghostize()is expected to work on all subtypes of/mobso it's a bad idea to access a variable that only exists on/mob/living(and there is no real point to movetimeofdeathup a level imo, we already have too much clutter there and/mob/camera/imaginary_friendwould never need it).Why It's Good For The Game
We should only access variables like these when when they exist.
Changelog
No shot a player would ever notice this