[MIRROR] Ancient Milsim Bitrunning Domain #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dedw * a-and it's done * after-playtest tweaks * Update ancient_milsim.dmm * crying rn * AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA * Update ancient_milsim.dmm * After-test tweaks part 2 * Update health_station.dmi * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * otherwise it becomes unplayable * 'ate invisible sprites * Apply suggestions from code review Co-authored-by: Bloop <[email protected]> * Update belt.dmi * Update belt.dmi * Reward expansion pack and other stuff * oops it compiled???? * Turns out it's built-in * Update mod.dm * Stupid bullshit * Rebalancing loadouts a bit * apparently armor is overriden by Skyrat * fixed? * Update outfit.dm * Update ancient_milsim.dmm --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 27, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* General maintenance for Lathes (#81244)
## About The Pull Request
1. **Qol Stuff**
- Screentips & examines for screwdriver, crowbar acts, multiool &
wirecutter Also for Alt click
- Techfabs can now also use the Mouse drag functionality to set drop
target for items
- Lathe printing animation now plays on loop instead of just flicking
once till printing is finished for more visual feedback
2. **Code Improvements**
- Merged `start_making()` with `do_make_item()`. That proc was like only
3 lines long and used only in 1 place so let's just move that code to
`ui_act()`
- Merged `user_print_item_id()` with `ui_act()`. Again was used only in
1 place so let's just move that code in to save some proc overhead
- Sets `processing_flags` for autolathe to `NONE` cause we don't use
`process()`
- Autodocs vars such as `hacked` , `shocked` etc & procs
- `maxmult` is now computed client side saving backend bandwidth,
`construction_time` is removed from lathes which did not use it
- Removed all usages of lathe taxes and their related vars, removed
engineering lathe no tax from ice moon, replaced with normal engineering
lathe
3. **Fixes**
- Lathe sheet insertion animations are now linked & work again for all
material types inserted via remote silo/local storage,
silver/titanium/plastic all play the same animation(that is
`protolathe_shiny` overlay). Other materials have their own respective
overlays
- Fixes #81243. Calling `update_static_data_for_all_viewers()` is too
expensive for the UI. We should instead use `SStgui.update_uis(src)`
which will report the `busy` status to the UI more immediatly
- Fixes #81236. Some problems with the params passed to the timer
callback. It should now print the correct number of requested items
- Fixes #81192. `design.materials` would runtime for custom material
items as they were list of texts not materials. We have to pass our
manually parsed list of materials for an specific item to ensure they
are set & used correctly. Same fixes apply for techfabs as well
## Changelog
:cl:
qol: adds screentips & examines for screwdriver & crowbar acts & alt
click.
qol: techfabs can now use the mouse drop functionality to set drop
target.
qol: lathe printing animation plays on loop while printing rather than
flicking once for more visual feedback
fix: lathe sheet insertion animations are now linked & work again for
all material types inserted via remote silo/local storage
fix: printing custom materials items from autolathe works again.
fix: printing multiple items from lathes will actually print that
correct quantity of items requested.
fix: printing items the 2nd time around from lathes won't cause the UI
to reload each time.
code: autodoc for some vars & procs, merges procs.
refactor: Optimized code for autolathe & techfabs in general. Report
bugs on github
/:cl:
---------
Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Ghom <[email protected]>
* General maintenance for Lathes
* should fix all the stuff
* yeah that one is on me
* fixes dme
* they gotta stop privating procs this shit sucks
* ok
* do not the register context
---------
Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: Ghom <[email protected]>
Co-authored-by: Paxilmaniac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24751
About The Pull Request
Adds a new PvE&P domain based around the SolFed-NRI/CIN Border War. Features a landmine field and a whole new gear disk acquired as a reward for completion.
How This Contributes To The Skyrat Roleplay Experience
Content good????
I always found it sad that the amount of roughly equally balanced PvP-centered domains was lacking, and since no one has added anything new in the span of the past few months bitrunners have existed, I've decided to add one myself.
Proof of Testing
Screenshots/Videos
Fog of war mechanics actually working. First screenshot before the button press, second's after:We also have a whole playtest video!!!! Some minor details were, indeed, changed, but otherwise it's almost entirely the same.
https://youtu.be/IjjHhfEXal8
Changelog
🆑 Stalkeros
add: "Ancient Milsim" bitrunning domain that lets you shoot guns at CIN people as SolFed people.
code: Added a way to add Skyrat-exclusive virual domain safehouses.
/:cl: