Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [SEMI-MODULAR] Resonance degradation disorder: The quirk that makes you fear death #840

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24041

About The Pull Request

Adds a new quirk: Resonance degradation disorder, a 0 cost "neutral" quirk that's only neutral due to its high customizability.

By default, you degrade each time you die. The higher your degradation, the lower your crit threshold and the higher your minimum stamina damage (you get tired each time you die, basically). You very very slowly heal when alive, which is expedited by resting, sleeping, or using rezadone.

Many other config options are available. Ex. You can configure how much you degrade while dead, how much formaldehyde/stasis reduces said degradation by, you can configure the rezadone effect, how much you heal, the exact mins/maxes of the crit rheshold/stamina damage, and...

What makes it DNR+,

The ability to be permanantly killed when your degradation reaches max.

Other features include: The ability to, via a verb, alter your degradation artificially. The ability to, via a verb, refresh your degradation settings so you can change how your degradation works on the fly. Feedback messages to you and everyone around you on death, PK, etc. A drop-down in settings that allows this customization without clogging it up too much.

The verbs are available to ghosts alongside carbons, meaning as a ghost, you can change your degradation. This is because these verbs are mainly OOC constructs, and a way for you as a player to modify your degradation, not as a way for your character to.

How This Contributes To The Skyrat Roleplay Experience

I never liked DNR. It's too sudden with how much death happens here. DNR is also supposed to give people a reason to fear death, but for many, they have a specific "range" of how much fear they want to inject. I dont want to be downright terrified myself, I just want to be worried and adverse to it.

This quirk does that by giving immense customization and non-DNR effects to death.

Proof of Testing

Screenshots/Videos
2023-09-30.15-08-09.mp4

Changelog

🆑 nikothedude
add: Resonance degradation disorder, a highly customizable quirk that acts as a far more in-depth version of DNR
/:cl:

…ou fear death (#24041)

* h

* fsfesef

* awdad

* asdf

* sew

* AA

* dadaw

* fix ci

* aaaa

* a

* aaaa

* dwaawd

* t

* just style

* voila

* we did it reddit

* a

* topic time

* a few tweaks

* Apply suggestions from code review

Co-authored-by: Bloop <[email protected]>

* more verbose

* piss

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <[email protected]>

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <[email protected]>

* basic reviews and some better documentation

* TGUI AAAAAAAAAAAAAAAH

* a

* maybe this

* reduce medicine number

* Update code/__DEFINES/~skyrat_defines/quirks.dm

how did i miss this one

Co-authored-by: GoldenAlpharex <[email protected]>

* the great middlewarening

* why did i check for this (hint: i had no reason to)

* final touches

* step 1

* step two

* why are we still here. just to suffer?

* grammar

* me when [single indentation]

* desparation

* some more!

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <[email protected]>

* finally

* acl

* a

* global moment

* desc moment

* fixes

* I FORGOT TO FUCKING COMMIT IT

* aaghhhh

* aha!

* yahoo

* Makes it work with the transformation sting PR (it won't conflict anymore)

* Updates the string into the proper define, so Niko doesn't notice or have to care that I did this

* k,l

---------

Co-authored-by: Bloop <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
@Iajret Iajret merged commit dfc55af into master Nov 28, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24041 branch November 28, 2023 22:36
AnywayFarus added a commit that referenced this pull request Nov 28, 2023
Iajret pushed a commit that referenced this pull request Feb 8, 2024
… initator open, fixes some surgeries missing sounds (#840)

* Fixes surgeries runtiming constantly when having the surgery initator open, fixes some surgeries missing sounds (#81307)

Fixes #79318

- See the issue for more information. I fixed the runtimes as expected,
and then removed `SURGERY_REQUIRE_LIMB` from some surgeries which don't
actually require a limb, such as implant removal, dissection, and living
revival. I could've easily missed some, and as a result some surgeries
are lost to the void and unselectable, but from what I could tell in
testing it seems... fine.

- Adds `SHOULD_CALL_PARENT` to surgery `can_start`. Cleans up some
surgery `can_start` overrides.

- Adds missing sounds to puncture repair surgery.

:cl: Melbert
fix: Fixed Puncture Repair surgery not having surgical sounds
fix: Fixed Surgery Initiator potentially showing invalid surgeries
/:cl:

* Fixes surgeries runtiming constantly when having the surgery initator open, fixes some surgeries missing sounds

* Update robot_brain_surgery.dm

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants