[MIRROR] Romerol tumors in living non-zombies don't delete on death #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MDB IGNORE] (#25278) * Romerol tumors in living non-zombies don't delete on death (#79945) ## About The Pull Request Romerol tumors have been broken for over a month because Melbert made them delete on host death, without realizing that people without `TRAIT_NODEATH` can have them (namely, non-zombies). This simply puts the self-deletion behind an `iszombie` check. ## Why It's Good For The Game This was an oversight that went under the radar until I saw someone get denied a zombie outbreak because of it. ## Changelog :cl: fix: People exposed to romerol while alive will once again revive as zombies on death. /:cl: Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com> * Romerol tumors in living non-zombies don't delete on death --------- Co-authored-by: Y0SH1M4S73R <[email protected]> Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Nov 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Adds head-only target hotkey (#81222) ## About The Pull Request Adds a new optional hotkey that targets only the head and does not cycle to eyes or mouth. Currently the way the numpad hotkeys work on /tg/ is every key targets one body part... except 8. Numpad 8 Currently cycles through head-eyes-mouth, despite _**numpad 7 already handling mouth and numpad 9 already handling eyes**_. There's no head-only key. * Adds head-only target hotkey --------- Co-authored-by: Swift <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Adds head-only target hotkey (#81222) ## About The Pull Request Adds a new optional hotkey that targets only the head and does not cycle to eyes or mouth. Currently the way the numpad hotkeys work on /tg/ is every key targets one body part... except 8. Numpad 8 Currently cycles through head-eyes-mouth, despite _**numpad 7 already handling mouth and numpad 9 already handling eyes**_. There's no head-only key. * Adds head-only target hotkey --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Swift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25278
Original PR: tgstation/tgstation#79945
About The Pull Request
Romerol tumors have been broken for over a month because Melbert made them delete on host death, without realizing that people without
TRAIT_NODEATHcan have them (namely, non-zombies). This simply puts the self-deletion behind aniszombiecheck.Why It's Good For The Game
This was an oversight that went under the radar until I saw someone get denied a zombie outbreak because of it.
Changelog
🆑 Y0SH1M4S73R
fix: People exposed to romerol while alive will once again revive as zombies on death.
/:cl: