[MIRROR] Removes some code soul (IF YOU ARE COPY PASTING THIS...), replaces it with a macro
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…replaces it with a macro [MDB IGNORE] (#25272)
* Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro (#79935)
## About The Pull Request
Replaces all instances of `SSblackbox.record_feedback\("tally",
"admin_verb", 1, (.+)\)` with `BLACKBOX_LOG_ADMIN_VERB($1)`
This makes so the funny comment isn't necessary.
It also reveals one location which someone did not heed the comment, the
`debug_controller` proc copy+pasted the line but did not change the
fourth argument. PEOPLE DON'T READ!
* Removes some code soul (`IF YOU ARE COPY PASTING THIS...`), replaces it with a macro
---------
Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Fix Krav Maga not shoving (#81340) ## About The Pull Request I thought it was normal for Krav to not shove but apparently it was reverted ## Changelog :cl: Melbert fix: Krav Maga users can shove again /:cl: * Fix Krav Maga not shoving --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Fix Krav Maga not shoving (#81340) ## About The Pull Request I thought it was normal for Krav to not shove but apparently it was reverted ## Changelog :cl: Melbert fix: Krav Maga users can shove again /:cl: * Fix Krav Maga not shoving --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25272
Original PR: tgstation/tgstation#79935
About The Pull Request
Replaces all instances of
SSblackbox.record_feedback\("tally", "admin_verb", 1, (.+)\)withBLACKBOX_LOG_ADMIN_VERB($1)This makes so the funny comment isn't necessary.
It also reveals one location which someone did not heed the comment, the
debug_controllerproc copy+pasted the line but did not change the fourth argument. PEOPLE DON'T READ!