Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] No currency symbol for free products #853

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25284
Original PR: tgstation/tgstation#79950

About The Pull Request

I have removed the currency icon for free products

Basic vendor menu:
BaseVendor

Custom vendor:
Owner's view
CustomOwnerVendor
Client's view:
CustomVendor

Why It's Good For The Game

I don't think it's important to know what currency the free product is measured in, since in the end it won't affect anything. The buttons look better without Cr

Changelog

🆑 FeudeyTF
code: Removed currency value for free products
/:cl:

* No currency symbol for free products (#79950)

## About The Pull Request

I have removed the currency icon for free products

**Basic vendor menu:**

![BaseVendor](https://github.com/tgstation/tgstation/assets/72273449/046be357-1623-4cf2-91ea-ff6663b20f78)

**Custom vendor:**
Owner's view

![CustomOwnerVendor](https://github.com/tgstation/tgstation/assets/72273449/3e959fcb-e389-40d6-943e-fecc5f6ee560)
Client's view:

![CustomVendor](https://github.com/tgstation/tgstation/assets/72273449/f9d8a60b-2b4c-4263-90f1-3d97a95c1241)

## Why It's Good For The Game

I don't think it's important to know what currency the free product is
measured in, since in the end it won't affect anything. The buttons look
better without Cr

## Changelog

:cl:
code: Removed currency value for free products
/:cl:

* No currency symbol for free products

---------

Co-authored-by: FeudeyTF <[email protected]>
@FeudeyTF
Copy link
Contributor

Хорошая обнова👍

@ReezeBL ReezeBL merged commit 6f2f430 into master Nov 28, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25284 branch November 28, 2023 05:19
AnywayFarus added a commit that referenced this pull request Nov 28, 2023
Iajret pushed a commit that referenced this pull request Feb 9, 2024
* Fix finger gun chat messages (#81347)

## About The Pull Request

It should not say "[the guy that you're aiming at] fires their gun"

## Changelog

:cl: Melbert
fix: Fixed Finger Guns giving a misleading chat message
/:cl:

* Fix finger gun chat messages

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants