Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Removes the radiation storm from the Radioactive Nebula station trait #854

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#24839

About The Pull Request

The title says it all, really.

How This Contributes To The Skyrat Roleplay Experience

I didn't originally disable it because I wanted to see what it would be like, giving it the benefit of the doubt. It went just like I expected it to, and I'm disabling it for the same reason we disabled the radstorm random event.

I've actually went through and disabled the radiation storm only from this event, meaning that the shielding can still technically be used, even if it won't do anything, it'll make some tritium. And generally speaking, space will still be radioactive.

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 GoldenAlpharex
del: The Radioactive Nebula station trait will no longer cause radiation storms, but all of its other effects remain.
/:cl:

… (#24839)

* Removes the Radioactive Nebula station trait from the station traits pool

* Updates the station trait so that it simply never runs the radiation storm

* Tweaks this slightly

* Lets admins toggle the storms on/off

* Revert "Lets admins toggle the storms on/off"

This reverts commit c4a56e2701ee8ad44e0cd922ac731c239a01f1e1.

* Let's try this again

* Update negative_traits.dm

* Update negative_traits.dm

* Update negative_traits.dm

* Update negative_traits.dm

---------

Co-authored-by: Bloop <[email protected]>
@Iajret Iajret merged commit b63805f into master Nov 29, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24839 branch November 29, 2023 14:16
AnywayFarus added a commit that referenced this pull request Nov 29, 2023
Iajret pushed a commit that referenced this pull request Feb 9, 2024
* Fix `get_visual_offset` results being reversed (#81348)

## About The Pull Request

Height -> width, width -> height

## Changelog

:cl: Melbert
fix: You know that one bug that makes the cryo cells on Deltastation
unusuable? Well it's not fixed but at least those cryo cells are usuable
again, maybe at the cost of another station's cryo cells. Who knows!
/:cl:

* Fix `get_visual_offset` results being reversed

---------

Co-authored-by: MrMelbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants