[MIRROR] Donator Item, Smol42 #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aoaoao * Update modular_skyrat/modules/customization/modules/clothing/~donator/donator_clothing.dm Co-authored-by: Bloop <[email protected]> --------- Co-authored-by: Bloop <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 28, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 9, 2024
…855) * `pixel_w` and `pixel_z` are included in `get_visual_offset` (#81349) ## About The Pull Request Closes #81095 Includes `pixel_w` and `pixel_z` in calculating an icon's `get_visual_offset`. Why? In particular, `get_visual_offset` is supposed to return how _visually_ offset an atom is from its loc. `pixel_w` and `pixel_z`, while they do not physically represent the same things as `pixel_x` and `pixel_y` (in that they're actually vertical (as seen with client dir)), still contribute to where an atom visually sits to the user. You may call this another nail in the client dir coffin if you wish. This proc is intended for visual use anyways, so anything using it for physical boundaries is wrong anyways. ## Changelog :cl: Melbert fix: Fixed some situations in which you couldn't interact with heretic runes /:cl: * `pixel_w` and `pixel_z` are included in `get_visual_offset` --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25196
About The Pull Request
Adds donator item for Smol42 sprited from scratch by Smol42.
Proof of Testing
Changelog
🆑 Smol42
add: Added custom donator item.
/:cl: