Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Improves tgui build speed #862

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[MIRROR] Improves tgui build speed #862

merged 1 commit into from
Nov 28, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25290
Original PR: tgstation/tgstation#79916

About The Pull Request

Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking:

Test environment / My specs

intel i7-13700kf
32GB RAM
windows 11
intel 660p m.2 SSD
asus 4080 TUF series

Fresh build

Test steps:

  1. Delete tgui/.yarn/webpack folder
  2. CTRL SHIFT B

Results:
fresh

terser averages 25.16s
esbuild averages 19.37s - 23% faster

Cached build

(assuming files are already there, CTRL SHIFT B if not)

  1. add a comment to an interface file
  2. CTRL SHIFT B

Results:
cached

terser averages 9s
esbuild averages 3.52s - 60.91% faster

Why It's Good For The Game

Faster dev environment

Changelog

N/A nothing player facing

* Improves tgui build speed (#79916)

## About The Pull Request
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine
behind vite. This is a pretty straight forward replacement, let's let
the numbers do the talking:

<details>
<summary>Test environment / My specs</summary>

intel i7-13700kf
32GB RAM
windows 11
intel 660p m.2 SSD
asus 4080 TUF series

</details>

<details>
<summary>Fresh build</summary>

Test steps:

1. Delete `tgui/.yarn/webpack` folder
2. `CTRL SHIFT B`

Results:

![fresh](https://github.com/tgstation/tgstation/assets/42397676/f337366f-2260-41b7-9ad6-f81f6f78e9e7)

terser averages `25.16s`
esbuild averages `19.37s` - 23% faster

</details>

<details>
<summary>Cached build</summary>

(assuming files are already there, CTRL SHIFT B if not)

1. add a comment to an interface file
2. `CTRL SHIFT B`

Results:

![cached](https://github.com/tgstation/tgstation/assets/42397676/89dc1c4b-a5b4-436d-a7e2-86683b6168f4)

terser averages `9s`
esbuild averages `3.52s` - 60.91% faster

</details>

## Why It's Good For The Game
Faster dev environment
## Changelog
N/A nothing player facing

* Improves tgui build speed

---------

Co-authored-by: Jeremiah <[email protected]>
@Iajret Iajret merged commit fe7fa9e into master Nov 28, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25290 branch November 28, 2023 23:38
Iajret pushed a commit that referenced this pull request Feb 9, 2024
* Removes Halloween Screen Tint (#81355)

## What

Reverts tgstation/tgstation#79062

## Why

It was a good idea (I swear) but as an everpresent effect it is far too
oppressive and opinionated. It causes issues for people with less then
perfect vision, fucked monitor setups (many people it seems) or those
who play in the day (can you tell when I do most of my development?)

I plan on reusing the concept of bracketing to implement conditional
nightvision that makes bright things blow out your screen and such, but
that's not happening for a while. I still think it was pretty but it's
not worth it

## Changelog
:cl:
del: Removes halloween screen tint, we're taking him to retire by the
seaside (he was alone and unloved)
/:cl:

* Removes Halloween Screen Tint

---------

Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants