[MIRROR] Fixes destructive analyzer being unable to research anything #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [MDB IGNORE] (#25296) * Fixes destructive analyzer being unable to research anything (#79953) ## About The Pull Request https://github.com/tgstation/tgstation/blob/62165b992df9e3b969519d6cfd776c6479c40743/code/modules/research/destructive_analyzer.dm#L184 placed after `loaded_item` is nulled, so it runtimes and fails to unhide any nodes. I've just saved item's type to new variable. Hopefully, it doesn't make any harddels or other scary things.  ## Why It's Good For The Game less runtimes, more things that works as they should ## Changelog :cl: fix: You can now destructively analyze syndicate and abductor items. It works this time, I promise! /:cl: * Fixes destructive analyzer being unable to research anything --------- Co-authored-by: Iajret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25296
Original PR: tgstation/tgstation#79953
About The Pull Request
https://github.com/tgstation/tgstation/blob/62165b992df9e3b969519d6cfd776c6479c40743/code/modules/research/destructive_analyzer.dm#L184 placed after
loaded_itemis nulled, so it runtimes and fails to unhide any nodes. I've just saved item's type to new variable. Hopefully, it doesn't make any harddels or other scary things.Why It's Good For The Game
less runtimes, more things that works as they should
Changelog
🆑 Iajret
fix: You can now destructively analyze syndicate and abductor items. It works this time, I promise!
/:cl: