Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Improves Cursed Items Wizard Event #868

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25299
Original PR: tgstation/tgstation#79941

About The Pull Request

I was bored and stumbled upon this and I remembered how pissed off I got that smoke would spawn on all humans during this event despite nothing magical happening to them. So, I fixed that (as well as saving us from iterating through alive_mob_list TWICE) and did some other code improvements while in the area.

  • We use define keys instead of raw strings (typo prevention)
  • No more single-letter variables (way more readable too)
  • Better indentation
  • Better list multilining
  • Some more documentation
  • Use legitimate boolean dichotomy

yep it looks good

Why It's Good For The Game

you don't get smoke spawning on you for no reason at all when you didn't do anything

Changelog

🆑 san7890
fix: During the "Cursed Items" wizard event, you should only have smoke spawn on you if you actually had a cursed item equipped to you.
/:cl:

* Improves Cursed Items Wizard Event

* Update curseditems.dm

* Update curseditems.dm

---------

Co-authored-by: san7890 <[email protected]>
Co-authored-by: Giz <[email protected]>
@Iajret Iajret merged commit ef39b52 into master Nov 29, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25299 branch November 29, 2023 09:12
AnywayFarus added a commit that referenced this pull request Nov 29, 2023
Iajret pushed a commit that referenced this pull request Feb 13, 2024
* New Primitive Tool + Iron Rods Can Be Melted

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: GoldenAlpharex <[email protected]>

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: GoldenAlpharex <[email protected]>

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: GoldenAlpharex <[email protected]>

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/reagent_forging/code/forge.dm

Co-authored-by: Bloop <[email protected]>

* fix iron rod result + consumption amount

---------

Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: Bloop <[email protected]>
ReezeBL pushed a commit that referenced this pull request Feb 13, 2024
* New Primitive Tool + Iron Rods Can Be Melted

* Update modular_nova/modules/reagent_forging/code/forge.dm



* Update modular_nova/modules/reagent_forging/code/forge.dm



* Update modular_nova/modules/reagent_forging/code/forge.dm



* Update modular_nova/modules/reagent_forging/code/forge.dm



* Update modular_nova/modules/reagent_forging/code/forge.dm



* Update modular_nova/modules/reagent_forging/code/forge.dm



* fix iron rod result + consumption amount

---------

Co-authored-by: MortoSasye <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants