[MIRROR] The synth brain surgery now targets the chest and only applies for synths #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nths (#25308) * It's a synth surgery * This might be a bit better * organising
AnywayFarus
added a commit
that referenced
this pull request
Nov 29, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Fixes screwdriver cocktail not being a screwdriver. (#81030) ## About The Pull Request Alternative title: The screwdriver cocktail is now the world's worst screwdriver (for real this time). As mentioned in my writeup in the related issue (#81017), as far as I know, it has never actually worked. Tl;dr: It requires `on_transfer` to be called with the method as ingestion, but in no way does transferring into a drinking glass ever use that method, and most ways don't even specify a method and thus `on_transfer` doesn't even get called in the first place. Then I went back to the original pr and tried it, and it didn't work. Then for resolving it, it feels unwieldy to do all this trickery on the reagent to change a value on the drinking glass when the drinking glass already has the perfect procs for this: the `on_cup_change` and `on_cup_reset` callbacks. Instead of using `on_transfer` and registering a hell of a lot of signals to re-check the master reagent every time the contents get changed, we just check whether the style we changed into is that of a screwdriver cocktail. This actually works. Oh, and I also added use sounds because it didn't have them, which I believe only actually get used when using it as a tool and thus only when it's a screwdriver. ## Why It's Good For The Game Fixes #81017. ## Changelog :cl: fix: As they should've for a while, screwdrivers (cocktail) actually work as screwdrivers (tool). sound: The screwdriver cocktail also actually plays the screwdriver sound when used. /:cl: --------- Co-authored-by: Ghom <[email protected]> * Fixes screwdriver cocktail not being a screwdriver. --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25308
About The Pull Request
It is a synth positronic brain surgery. The synth brain is defined with
zone = BODY_ZONE_CHESTyet the surgery targets the head. It also doesn't even check for only synths, as the name might imply.Well now it does
How This Contributes To The Skyrat Roleplay Experience
The surgery target should be on the place where the organ is, to avoid confusion between one and the other.
Proof of Testing
Screenshots/Videos
Here it is appearing on a synth Here it is not appearing on john doe
Changelog
🆑 Majkl-J
qol: Synth brain surgery now actually targets the synth brain location
/:cl: