Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix bitrunning triggering claustrophobia #886

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25327
Original PR: tgstation/tgstation#79944

About The Pull Request

Fixes #79226

Bitrunning while having claustrophobia would kill you after you left the VR pod. This is no longer the case since your mind is functionally outside of your body, which is similar to the other checks performed to see if you are unconscious.

Why It's Good For The Game

Consistency.

Changelog

🆑 timothymtorres
fix: Fix bitrunning triggering claustrophobia
/:cl:

* Fix bitrunning triggering claustrophobia (#79944)

## About The Pull Request
Fixes #79226

Bitrunning while having claustrophobia would kill you after you left the
VR pod. This is no longer the case since your mind is functionally
outside of your body, which is similar to the other checks performed to
see if you are unconscious.

## Why It's Good For The Game
Consistency.

## Changelog
:cl:
fix: Fix bitrunning triggering claustrophobia
/:cl:

* Fix bitrunning triggering claustrophobia

---------

Co-authored-by: Tim <[email protected]>
@Iajret Iajret merged commit 2dfee18 into master Nov 29, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25327 branch November 29, 2023 14:13
AnywayFarus added a commit that referenced this pull request Nov 29, 2023
Iajret pushed a commit that referenced this pull request Feb 11, 2024
…sinfo) (#886)

* Adds a signal to buying items from the uplink (& fixes TC misinfo) (#81372)

## About The Pull Request

Adds a signal when someone buys an item from the uplink and removes
single-letter vars from the ``spawn_item`` proc, and adds/standardizes
add/removing of telecrystals from uplinks (and admin setting how much TC
they have) to ensure the UI always has the right amount of telecrystals
displayed in it.

## Why It's Good For The Game

There are reasons why someone would want to hook up to a traitor's
uplink and listen to items they purchase to do any special effect
on-purchase, so this adds support to do anything in the future with it.
Also tells players how much TC they actually have without forcing them
to close/reopen the UI every time they insert some TC in it by hand.

## Changelog

:cl:
fix: Uplinks now update their UI when you add telecrystals in them, so
you don't need to close and reopen it.
/:cl:

* Adds a signal to buying items from the uplink (& fixes TC misinfo)

---------

Co-authored-by: John Willard <[email protected]>
ReezeBL pushed a commit that referenced this pull request Feb 11, 2024
…sinfo) (#886) (#1929)

* Adds a signal to buying items from the uplink (& fixes TC misinfo) (#81372)

## About The Pull Request

Adds a signal when someone buys an item from the uplink and removes
single-letter vars from the ``spawn_item`` proc, and adds/standardizes
add/removing of telecrystals from uplinks (and admin setting how much TC
they have) to ensure the UI always has the right amount of telecrystals
displayed in it.

## Why It's Good For The Game

There are reasons why someone would want to hook up to a traitor's
uplink and listen to items they purchase to do any special effect
on-purchase, so this adds support to do anything in the future with it.
Also tells players how much TC they actually have without forcing them
to close/reopen the UI every time they insert some TC in it by hand.

## Changelog

:cl:
fix: Uplinks now update their UI when you add telecrystals in them, so
you don't need to close and reopen it.
/:cl:

* Adds a signal to buying items from the uplink (& fixes TC misinfo)

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: John Willard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants