Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds localhost case to the Player Panel #891

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25333
Original PR: tgstation/tgstation#79999

About The Pull Request

image

This always confused me debugging on local, the thing in the parenthesis is supposed to the be the IP Address of the client currently in the mob. However, local hosts have a null IP Address (BYOND thing). So, let's add handling to this so this little thing won't be so confusing anymore

Why It's Good For The Game

image

Better.

Changelog

Not really relevant.

* Adds `localhost` case to the Player Panel (#79999)

## About The Pull Request

![image](https://github.com/tgstation/tgstation/assets/34697715/2fd2b8fd-dc86-4150-8f0f-b8ac6a5dc03c)

This always confused me debugging on local, the thing in the parenthesis
is supposed to the be the IP Address of the client currently in the mob.
However, local hosts have a `null` IP Address (BYOND thing). So, let's
add handling to this so this little thing won't be so confusing anymore
## Why It's Good For The Game

![image](https://github.com/tgstation/tgstation/assets/34697715/b365e107-cfcf-497c-92da-f5930666cbb0)

Better.
## Changelog
Not really relevant.

* Adds `localhost` case to the Player Panel

---------

Co-authored-by: san7890 <[email protected]>
@Iajret Iajret merged commit 9f249c7 into master Nov 30, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25333 branch November 30, 2023 11:51
Iajret pushed a commit that referenced this pull request Feb 11, 2024
… prefabs (#891)

* Replaces beach bar virtual domain varedited bar closets with prefabs (#81384)

## About The Pull Request

This changes the varedited/manually populated bar closets in the
lavaland virtual domain with the proper prefabs used on lavaland.
## Why It's Good For The Game

The doors don't look wonky now.


![image](https://github.com/tgstation/tgstation/assets/28870487/109ed9d5-762f-48ee-953e-6c669b51bbeb)
## Changelog
:cl: Rhials
fix: The beach bar virtual domain's bar closets no longer have default
locker doors.
/:cl:

* Replaces beach bar virtual domain varedited bar closets with prefabs

---------

Co-authored-by: Rhials <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants