[MIRROR] Deletes area var on clients
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deletes `area` var on clients (#80037) ## About The Pull Request Literally nothing wrote to or accessed this variable, in pretty much _every_ case we just use `get_area(mob)` instead of ever looking at the client's area (again, ???) ## Why It's Good For The Game this variable was added 12 years ago and I don't think anyone has ever novelly used this. ## Changelog Doesn't matter to players. * Deletes `area` var on clients --------- Co-authored-by: san7890 <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 11, 2024
…e it is eaten (#897) * Fixes the energy cake slice's on-eat effect triggering before it is eaten (#81382) ## About The Pull Request This makes the energy cake deal its damage/effects AFTER being fed, instead of before. It also adds combat logging to force-fed energy cakes, just in case. Also, this adds a balloon alert to the pacifist check. Cool! ## Why It's Good For The Game Fixes a wacky combat bug, and adds some minor adjustments made along the way. Closes #81351. ## Changelog :cl: Rhials fix: The Energy Cake slice now does its on-eat effect AFTER being eaten, instead of before. /:cl: * Fixes the energy cake slice's on-eat effect triggering before it is eaten --------- Co-authored-by: Rhials <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 11, 2024
…e it is eaten (#897) (#1928) * Fixes the energy cake slice's on-eat effect triggering before it is eaten (#81382) ## About The Pull Request This makes the energy cake deal its damage/effects AFTER being fed, instead of before. It also adds combat logging to force-fed energy cakes, just in case. Also, this adds a balloon alert to the pacifist check. Cool! ## Why It's Good For The Game Fixes a wacky combat bug, and adds some minor adjustments made along the way. Closes #81351. ## Changelog :cl: Rhials fix: The Energy Cake slice now does its on-eat effect AFTER being eaten, instead of before. /:cl: * Fixes the energy cake slice's on-eat effect triggering before it is eaten --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Rhials <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25358
Original PR: tgstation/tgstation#80037
About The Pull Request
Literally nothing wrote to or accessed this variable, in pretty much every case we just use
get_area(mob)instead of ever looking at the client's area (again, ???)Why It's Good For The Game
this variable was added 12 years ago and I don't think anyone has ever novelly used this.
Changelog
Doesn't matter to players.