[MIRROR] Removes some done todos (and ones that I think are dumb) #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B IGNORE] (#25362) * Removes some done todos (and ones that I think are dumb) (#80017) ## About The Pull Request Most of these are mine that I just forgot about, only one I think anyone cares about is the one in mobs.dm about making delta time match subsystem yielding, but I think it's a bad idea so it's gone Oh also, replaces an old comment of mine with an actual explanation (it's about the icon cache and shit) * Removes some done todos (and ones that I think are dumb) --------- Co-authored-by: LemonInTheDark <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 11, 2024
…ions (#899) * Allows shakers to pour drinks with custom names and descriptions (#81234) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This adds the ability for shakers to pour drinks with custom names and descriptions. You can alt-click on a shaker and it will prompt you to set the name and desc for the drink, and they will be given to description of whatever drinking glass you pour into. Washing the glass will remove these customization (it will also now remove any changes made using a pen). https://github.com/tgstation/tgstation/assets/42454181/6cf336f0-0621-49f3-baf1-91038f454c24 <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game While this already kind of exists by using a pen to change the name and desc, this is pretty annoying to do for every single glass of a beverage you serve. It also is overwritten whenever the kind of drink in the glass is changed. This PR will let bartenders serve plenty of their own special concoctions without having to rename every single glass they serve. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: add: Shakers can now pour drinks with custom names and descriptions! Alt-click the shaker to enable this. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Ghom <[email protected]> * Allows shakers to pour drinks with custom names and descriptions --------- Co-authored-by: Nick <[email protected]> Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25362
Original PR: tgstation/tgstation#80017
About The Pull Request
Most of these are mine that I just forgot about, only one I think anyone
cares about is the one in mobs.dm about making delta time match
subsystem yielding, but I think it's a bad idea so it's gone
Oh also, replaces an old comment of mine with an actual explanation (it's about the icon cache and shit)