Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Lings no longer get impossible identity theft objectives #900

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25364
Original PR: tgstation/tgstation#80012

About The Pull Request

Crew with TRAIT_NO_DNA_COPY are no longer valid targets for identity theft objectives. Changes some code to make it easier to exclude potential objective targets.
Changelings that roll an identity theft objective while there are no valid targets will now get an ordinary escape objective rather than a free objective.

Fixes #77764

Why It's Good For The Game

Objectives are usually meant to be achievable.

Changelog

🆑 TJatPBnJ
fix: Changelings will no longer get an objective to impersonate crew without absorbable DNA.
fix: Changelings will no longer start without an escape objective.
/:cl:

…B IGNORE] (#25364)

* Lings no longer get impossible identity theft objectives

* Fix Conflict, Preserve SR Addition

* Should be Fixed now

* Fix Compile Error

---------

Co-authored-by: TJatPBnJ <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
@Iajret Iajret merged commit 2238209 into master Dec 1, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25364 branch December 1, 2023 18:56
AnywayFarus added a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants