[MIRROR] Fixes Callback Trait Addition/Removal Oversight #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#25361) * Fixes Callback Trait Addition/Removal Oversight (#80009) ## About The Pull Request This pissed me off working yesterday, traits are supposed to work on the `/datum` level, not just the `/atom` level. Let's fix that, while also cleaning up the code a bunch to make it look better and have error logging for unwanted cases. ## Changelog Nothing that concerns players. * Fixes Callback Trait Addition/Removal Oversight --------- Co-authored-by: san7890 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25361
Original PR: tgstation/tgstation#80009
About The Pull Request
This pissed me off working yesterday, traits are supposed to work on the
/datumlevel, not just the/atomlevel. Let's fix that, while also cleaning up the code a bunch to make it look better and have error logging for unwanted cases.Changelog
Nothing that concerns players.