[MIRROR] Retools IS_SPINNING_1 into a trait
#955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retools `IS_SPINNING_1` into a trait * Modular --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: Bloop <[email protected]>
Steals-The-PRs
added
Mirroring conflict
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Enable powercord implant to charge from any battery * Simplify conditionals * Fix grammar * Reposition do_after delay argument * Cleanup naive approach * Swap direct array access for function call * Rename static/global variable to be less generic * Repathed apc_powercord to synth_powercord and renamed its parent implant to 'charging implant' * Update comments Co-authored-by: Bloop <[email protected]> * Update comments Co-authored-by: Bloop <[email protected]> * Update comments Co-authored-by: Bloop <[email protected]> * Update comments Co-authored-by: Bloop <[email protected]> * Convert some chat messages to balloon alerts Co-authored-by: Bloop <[email protected]> * Fix bug preventing early return for maximum nutrition, convert chat message to balloon alert * Change usage of contents to items_to_create --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25399
Original PR: tgstation/tgstation#80060
About The Pull Request
This did NOT need to be on the
/atomlevelflags_1- when on earth is an area going to spin? Anyways, this was really only ever used on the/mobsublevel inspin()code, but I think this would work far better as a trait for source-management than moving it to a mob flag or something. So, let's do that.Why It's Good For The Game
Frees up a slot on
flags_1, which is neat, as well as makes the framework for managing "things that make you spin" potentially better for future expansion. It also properly scopes something that only works for mobs right now to mobs (kinda), so it's a bit better that way too.Changelog
Nothing that concerns players.