[MIRROR] The maintenance crate spawning crate is now a spawner #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GNORE] (#25417) * The maintenance crate spawning crate is now a spawner (#80083) `/obj/structure/closet/crate/maint` was a type of crate that spawned a completely different crate, and then deleted itself. I have decided to swap this out for an actual spawning effect. I have also did some subtypery to remove some duplicate code that handled randomly opening the spawned closet/crate (through I am not that satisfied with `/obj/effect/spawner/random/structure/closet_empty/crate/with_loot` as a sensible typepath name, I would like to ask for suggestions). I also removed a loot define, because it was no longer needed as its contents were used on a single page. Things that act like spawners should be spawners. Maybe this fixes the CI issue on northstar where a mousetrap box gets deleted before it initializes during create and destroy? It was placed above a spawner that spawned one of these self deleting crates. I am unsure, I could not replicate this issue during testing. Nothing player facing. * The maintenance crate spawning crate is now a spawner * UpdatePaths * Update Blueshift.dmm --------- Co-authored-by: Profakos <[email protected]> Co-authored-by: Giz <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-25417
Iajret
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Fixes Krav Maga allowing pacifism bypasses. (#81447) ## About The Pull Request Fixes Krav Maga allowing pacifism bypasses. ## Why It's Good For The Game Bugfixes are good for my GBP count. Also, pacifism bypasses bad. ## Changelog :cl: CandleJaxx and Iamgoofball fix: Fixes Krav Maga allowing pacifism bypasses. /:cl: * Fixes Krav Maga allowing pacifism bypasses. --------- Co-authored-by: Iamgoofball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25417
Original PR: tgstation/tgstation#80083
About The Pull Request
/obj/structure/closet/crate/maintwas a type of crate that spawned a completely different crate, and then deleted itself. I have decided to swap this out for an actual spawning effect.I have also did some subtypery to remove some duplicate code that handled randomly opening the spawned closet/crate (through I am not that satisfied with
/obj/effect/spawner/random/structure/closet_empty/crate/with_lootas a sensible typepath name, I would like to ask for suggestions). I also removed a loot define, because it was no longer needed as its contents were used on a single page.Why It's Good For The Game
Things that act like spawners should be spawners.
Maybe this fixes the CI issue on northstar where a mousetrap box gets deleted before it initializes during create and destroy? It was placed above a spawner that spawned one of these self deleting crates. I am unsure, I could not replicate this issue during testing.
Changelog
Nothing player facing.