[MIRROR] Fixes the labeler in accordance to the new action version #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the labeler in accordance to the new action version * Okay how about this? * Okay, how about this? * Update labeler.yml * Would this work instead? * Okay how about we go back * Update labeler.yml * Update labeler.yml * Update labeler.yml * Update .github/labeler.yml Co-authored-by: Jolly <[email protected]> * Update labeler.yml --------- Co-authored-by: Giz <[email protected]> Co-authored-by: Jolly <[email protected]>
Steals-The-PRs
added
Mirroring conflict
|
shit, sorry for that ping. I should've thought of that :) |
|
|
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Micro-Optimize keyLoop's self time (#81464) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This is a REALLY hot proc, takes up to like 2% of total cpu at highpop Let's micro it then First, clients do not go null at random. It's not predictable per say but it is consistent. We can use this understanding to remove a bunch of null checks here For loops are expensive. So rather then doing one each keyLoop, let's cache the client's intended move direction on the client. Simplifies some other code too There is no sense running a turn call if it would have no effect, let's be more intelligent about this ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: refactor: Fucks with how movement keys are handled. Please report any bugs /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> * Micro-Optimize keyLoop's self time --------- Co-authored-by: LemonInTheDark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25430
About The Pull Request
They updated the actions, and of course didn't really do anything to announce it ahead of time. Oh well, at least it was an easy fix.
Also @Jolly-66 because Tale will need this too.
How This Contributes To The Skyrat Roleplay Experience
Maintainers will be less depressed, which leads to better code, which leads to a better roleplay experience down the lineé
Proof of Testing
I'm testing it with this PR.
Changelog
None, it's GitHub stuff.