[MIRROR] Fix void adaptation not reapplying when born from a headslug #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [MDB IGNORE] (#25422) * Fix void adaptation not reapplying when born from a headslug (#80108) ## About The Pull Request This bug happend because of 2 things, 1. the traits where applied to the current mob on *purchase* 2. When head slug calls regain_powers, it uses the grant proc There are 2 solutions for this. Either make void adapatation apply its effects on grant or change regain powers to be on purchase. This would break admin bussing non ling events into a lings innate_powers. but saves having to rewrite all ling thingies from on_purchase to on_grant ## Why It's Good For The Game Permantly losing void adaptation because of last resort is meh ## Changelog :cl: fix: Rebirthing from headslug properly reapplys void adaptation /:cl: * Fix void adaptation not reapplying when born from a headslug --------- Co-authored-by: Autisem <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 5, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Fixes a runtime in engaged_role_play_check * Inverts the return value * Update ev_roleplay_check.dm * Update ev_roleplay_check.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25422
Original PR: tgstation/tgstation#80108
About The Pull Request
This bug happend because of 2 things,
There are 2 solutions for this. Either make void adapatation apply its effects on grant or change regain powers to be on purchase.
This would break admin bussing non ling events into a lings innate_powers. but saves having to rewrite all ling thingies from on_purchase to on_grant
Why It's Good For The Game
Permantly losing void adaptation because of last resort is meh
Changelog
🆑 Autisem
fix: Rebirthing from headslug properly reapplys void adaptation
/:cl: