Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix character prefs augments page boundaries #973

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: Skyrat-SS13/Skyrat-tg#25433

About The Pull Request

Due to an upstream change as we remove IE8 legacy code and move towards React, certain TGUI pages respond differently to certain CSS elements.

Fixes Skyrat-SS13/Skyrat-tg#25341 where the Augments+ page force scrolls and loses the main tab bar when trying to select an augment.

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 LT3
fix: The character prefs tab bar will no longer disappear when you try to select augments
/:cl:

@ReezeBL ReezeBL merged commit 72c1fe8 into master Dec 5, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-25433 branch December 5, 2023 07:09
AnywayFarus added a commit that referenced this pull request Dec 5, 2023
Iajret pushed a commit that referenced this pull request Feb 17, 2024
* Adds Subsystem Profile Focusing (#81461)

## About The Pull Request
adds a var to /subsystem that when toggled to true by an admin makes
/subsystem/ignite() start the profiler before calling fire() and then
stop the profiler after, this allows us to audit any individual
subsystems synchronous call chain.
## Why It's Good For The Game

![Screenshot_3275](https://github.com/tgstation/tgstation/assets/15794172/27d5e4b0-ab06-451f-b4b4-97d31fd06385)
when SSInput is focused

![Screenshot_3274](https://github.com/tgstation/tgstation/assets/15794172/55572861-3f71-4b6c-bb63-f1dfbbe2ab26)
when SSair is focused

some subsystems are hard to profile performance issues for because
theres a billion procs downstream of them in the profiler and some of
them arent even unique to them (if a subsystem is spending half of its
time in some procs downstream of /_SendSignal() how could you tell). now
we can just do it. starting (and stopping?) the profiler itself is
expensive and this messes with the full round profiler but this is worth
it.

also this doesnt help with sleeping procs / timers created downstream of
that subsystem.
## Changelog
:cl:
admin: admins/maintainers can now make the profiler focus on specific
subsystems by setting the subsystem var profile_focused to TRUE
/:cl:

* Adds Subsystem Profile Focusing

---------

Co-authored-by: Kylerace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augments Tab Force Scroll
3 participants