[MIRROR] [Modular] New Lockers! (Skyrat Edition) #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moves sec lockers to use modular file * Removes redundant /station subtype from NTC Locker * consistency with other stuff + its converted now (YOU'RE THE LAZY ASSHAT, ASSHAT.) * blueshield consistency with other lockers/bags * resprite all the modular closets (that I'm willing to do) * stop being mean. Asshat. * Resprites wall lockers (separate file so they can have working overlays) * Even if these don't work here's the icons so I don't lose them (again) * Wall mounts can be rebuilt! Yahoo! * oh I should probably push these whoops * fixes animations * removes an EVIL icon override we had buried
AnywayFarus
added a commit
that referenced
this pull request
Dec 7, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Salicylic acid & Oxandrolone now care about purity. (#81191) ## About The Pull Request Just makes salicylic acid and oxandrolone scale with purity (so they're consistent with libital & aiuri scaling) ## Why It's Good For The Game Now mass producing good salicylic acid / oxandrolone with a chem factory takes some effort. ## Changelog :cl: balance: Oxandrolone now scales with purity. Its default purity is 100% balance: Salicylic acid now scales with purity. Its default purity is 100% /:cl: * Salicylic acid & Oxandrolone now care about purity. --------- Co-authored-by: MLGTASTICa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#25409
About The Pull Request
#25245 Redone because it deleted my everything when I pushed it. So, I redid it. All of it.
PR is essentially Skyrat-SS13/Skyrat-tg#25167 but for our own lockers, plus some other maintenance and a little surprise.
Full Changelist:
/stationsubtype of the NTC Locker (this is the source of all map changes)To-Do: Sort out why the wall lockers have bounce on the animated state.Done, animation is now smooth!How This Contributes To The Skyrat Roleplay Experience
I love decrusting I love decrusting I love desouling I love desouling!!!!
Proof of Testing
Screenshots/Videos
Security LockersBlueshield
NTC
Barber (God that vendor needs to be redone)
Wall Lockers are now not only up-to-date... (these images are a tinyyy bit outdated tho. I made them like 1px shorter and cleaned the inside's shading a bit)
And have working overlays...
But can be re-built and mounted!
Changelog
🆑 OrionTheFox
qol: Wall Lockers can now be rebuilt! The wall mounts can be crafted the same as a default closet, with 2 iron in-hand.
image: resprites (almost) all Skyrat lockers, including wall-mounted ones! They should be much more in line with TG's sprites now.
fix: fixed several bugs with wall-mounted lockers, and formatting inconsistencies of modular lockers
/:cl: