Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore some private functions #2052

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Restore some private functions #2052

merged 1 commit into from
Aug 28, 2022

Conversation

ToucheSir
Copy link
Member

Ref. #2049. This is just a minimal fix to get downstream CI back to green while we wait for a resolution on that discussion.

These were breaking downstream tests on master
@codecov-commenter
Copy link

Codecov Report

Merging #2052 (6fddaf9) into master (6c747f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2052   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          18       18           
  Lines        1357     1357           
=======================================
  Hits         1170     1170           
  Misses        187      187           
Impacted Files Coverage Δ
src/deprecations.jl 33.33% <ø> (ø)
src/utils.jl 95.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ToucheSir ToucheSir merged commit 0840625 into master Aug 28, 2022
@ToucheSir ToucheSir deleted the bc/restore-private-fns branch August 28, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants