Narrower version of @non_differentiable params
#2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2040 is not reintroduced with this commit. Cheers! |
|
Seems like #2123 is what fixes the failing test and it was merged shortly after the CI was triggered. |
mcabbott
force-pushed
the
params_grad
branch
from
9cc8e25 to
aad89fc
Compare
|
Thanks! It passed initially, except for what was probably just buildkite having a bad day... now rebased to try again. |
ToucheSir
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #2054 with a narrower definition, to fix #2091
Exploits FluxML/Zygote.jl#1248 to essentially apply
@no_gradonly to implicit mode.@christiangnrd could you check that this doesn't re-introduce #2040? I am not getting consistent times but not sure why.