Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that is not broken anymore #2349

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

devmotion
Copy link
Contributor

It seems that Zygote 0.6.67 (i.e., FluxML/Zygote.jl#1328) fixed one test that is currently marked as broken: https://github.com/FluxML/Zygote.jl/actions/runs/6650603568/job/18071017146?pr=1467#step:6:744

Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI likes this!

@devmotion
Copy link
Contributor Author

CI seems happy (nightly and buildkite failures seem unrelated AFAICT).

@CarloLucibello CarloLucibello merged commit 4b4464a into FluxML:master Oct 26, 2023
5 of 7 checks passed
@devmotion devmotion deleted the dw/fix_tests branch October 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants