Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LazyString in depwarn #2400

Merged
merged 5 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Flux"
uuid = "587475ba-b771-5e3f-ad9e-33799f191a9c"
version = "0.14.13"
version = "0.14.14"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
4 changes: 2 additions & 2 deletions src/deprecations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ end
# Greek-letter keywords deprecated in Flux 0.13
# Arguments (old => new, :function, "β" => "beta")
function _greek_ascii_depwarn(βbeta::Pair, func = :loss, names = "" => "")
Base.depwarn("""function $func no longer accepts greek-letter keyword $(names.first)
please use ascii $(names.second) instead""", func)
Base.depwarn(LazyString("function $func no longer accepts greek-letter keyword ", names.first, """
mcabbott marked this conversation as resolved.
Show resolved Hide resolved
please use ascii """, names.second, " instead"), func)
βbeta.first
end
_greek_ascii_depwarn(βbeta::Pair{Nothing}, _...) = βbeta.second
Expand Down
2 changes: 1 addition & 1 deletion src/layers/macro.jl
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ end

function _check_new_macro(x::T) where T
Functors.isleaf(x) && return
Base.depwarn("This type should probably now use `Flux.@layer` instead of `@functor`: $T", Symbol("@functor"))
Base.depwarn(LazyString("This type should probably now use `Flux.@layer` instead of `@functor`: ", T), Symbol("@functor"))
end
_check_new_macro(::Tuple) = nothing # defined by Functors.jl, not by users
_check_new_macro(::NamedTuple) = nothing
Expand Down
Loading