Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Optimisers and remove params and Optimise from tests #2495

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Oct 11, 2024

Moving forward with the full deprecation of Flux.params and of the Optimise module, this removes them from tests and documentation.

After this only explicit differentiation and the Optimisers are used in the tests.

Moreover, now Flux exports the new optimisers from Optimisers.jl instead of the old Optimisers.
Should this change be considered breaking? yes
I guess it can break code for some people using implicit gradients.

Close #2413 close #1986

@CarloLucibello CarloLucibello marked this pull request as draft October 11, 2024 07:37
@CarloLucibello CarloLucibello force-pushed the cl/depr2 branch 3 times, most recently from 016dca9 to 2c3e257 Compare October 13, 2024 21:51
@CarloLucibello CarloLucibello marked this pull request as ready for review October 14, 2024 07:57
@mcabbott mcabbott added this to the v0.15 milestone Oct 16, 2024
remove Flux.params from tests

broken

deprecation in __old_to_new

pen2

remove params entirely

export Optimisers

cleanup

fix ambiguity

comment
@CarloLucibello CarloLucibello changed the title remove params and Optimise from tests Export Optimisers and remove params and Optimise from tests Nov 5, 2024
@CarloLucibello CarloLucibello merged commit e1989b5 into master Nov 5, 2024
6 of 9 checks passed
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 18.13%. Comparing base (7be1ca7) to head (34bbe77).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/deprecations.jl 0.00% 15 Missing ⚠️
src/layers/show.jl 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7be1ca7) and HEAD (34bbe77). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7be1ca7) HEAD (34bbe77)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2495       +/-   ##
===========================================
- Coverage   34.55%   18.13%   -16.43%     
===========================================
  Files          31       31               
  Lines        1904     1897        -7     
===========================================
- Hits          658      344      -314     
- Misses       1246     1553      +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcabbott mcabbott deleted the cl/depr2 branch November 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants