Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initialstates function to RNNs #2541

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

MartinuzziFrancesco
Copy link
Contributor

@MartinuzziFrancesco MartinuzziFrancesco commented Dec 5, 2024

Adding initialstates function as per discussion in #2514

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@MartinuzziFrancesco MartinuzziFrancesco changed the title added initialstates Adding initialstates function to RNNs Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.81%. Comparing base (74c3a63) to head (48402d7).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2541       +/-   ##
===========================================
+ Coverage   32.69%   65.81%   +33.12%     
===========================================
  Files          34       35        +1     
  Lines        1976     2030       +54     
===========================================
+ Hits          646     1336      +690     
+ Misses       1330      694      -636     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/layers/recurrent.jl Show resolved Hide resolved
src/layers/recurrent.jl Outdated Show resolved Hide resolved
@CarloLucibello
Copy link
Member

It should be defined also for RNN, LSTM, ....

@MartinuzziFrancesco
Copy link
Contributor Author

It should be defined also for RNN, LSTM, ....

Ah sorry I was meaning to ask, I'll go forward with that

@CarloLucibello
Copy link
Member

CarloLucibello commented Dec 9, 2024

Should test that the Flux.initialstates(rnn) returns what is supposed to return for all layers.

@CarloLucibello CarloLucibello merged commit 40b7f70 into FluxML:master Dec 10, 2024
9 of 11 checks passed
@CarloLucibello CarloLucibello mentioned this pull request Dec 12, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants