Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gpu_device not defined in Flux.DistributedUtils #2552

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

AntonOresten
Copy link
Contributor

@AntonOresten AntonOresten commented Dec 13, 2024

gpu_device was not explicitly imported in the DistributedUtils module, leading to an UndefVarError. Instead of importing it, this PR simply calls get_device on the buffer to get the device, as is done in the bcast! method from the same file, and the original Lux.jl implementation.

@AntonOresten AntonOresten changed the title fix: UndefVarError: gpu_device not defined in Flux.DistributedUtils fix: gpu_device not defined in Flux.DistributedUtils Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (9050ef0) to head (885d95d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/distributed/public_api.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2552       +/-   ##
===========================================
+ Coverage   32.78%   65.71%   +32.93%     
===========================================
  Files          34       35        +1     
  Lines        1998     2039       +41     
===========================================
+ Hits          655     1340      +685     
+ Misses       1343      699      -644     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntonOresten AntonOresten changed the title fix: gpu_device not defined in Flux.DistributedUtils hotfix: gpu_device not defined in Flux.DistributedUtils Dec 13, 2024
@CarloLucibello CarloLucibello merged commit 009d35b into FluxML:master Dec 13, 2024
8 of 11 checks passed
@AntonOresten AntonOresten changed the title hotfix: gpu_device not defined in Flux.DistributedUtils fix: gpu_device not defined in Flux.DistributedUtils Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants