Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the
walk::AbstractWalk
interface to naturally support recursion throughwalk(x, ys...)
and deprecates an oldfmap
signature; resolves #62.One subtle point: I wanted to leave the
recurse
first-arg exactly as is which would have made the diff even smaller. However, for the dispatch to work, we needed to restrict the first argrecurse
to be anAbstractWalk
when implementing walk subtypes, in which case it made more sense to call itouter_walk
, or something of that nature. [This is a breaking change for people who have defined custom walks, since custom subtypes of walk will need to make sure to have this dispatch. This leads to IMO the cleanest API, but I could use something more clunky thanwalk(x, ys...)
for the recursive walk and avoid the breaking change if desired. The main point of this PR is to show that something like therecurse
closure is not necessary]