Deprecate fmap(walk, f, x, ys...) for simpler runwalk function #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new structure avoids the need for a recursive closure
gaurav-arya
force-pushed
the
ag-runwalk
branch
2 times, most recently
from
da33115 to
cc92281
Compare
gaurav-arya
force-pushed
the
ag-runwalk
branch
from
cc92281 to
49aaeb0
Compare
|
Ack, this is probably breaking too due to the change in how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new structure avoids the need for a recursive closure. Resolves #62
Other than the deprecation, this should not be breaking according to the public API (and tests pass unchanged), although it should definitely be checked in practice.