Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that Flux optimiser is not being used #260

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

ablaom
Copy link
Collaborator

@ablaom ablaom commented Jun 11, 2024

This PR adds a check to the clean! method that throw an error if user passes an optimiser to a model that subtypes Flux.Optimise.AbstractOptimiser. Only optimisers from Optimisers.jl are now supported, and the error message explains as much.

@ablaom ablaom merged commit 06282cd into dev Jun 11, 2024
6 checks passed
@ablaom ablaom deleted the optimiser-warning branch June 11, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant