Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UNet Model #210
Adding UNet Model #210
Changes from 21 commits
ba54cf0
11c50d9
ca73586
552a8fd
c577aed
fb642c4
7c7b1ee
99f07ad
fc756d9
60b082c
2f1cc6d
8d2ba2b
77a3148
8aebd14
429096b
d761126
1b5d2b7
354e3c4
6494be7
2d68f61
627480f
4012fb2
016cef4
6097c57
98b4c30
54c334f
4fae8d6
4735dff
3bebe5a
65aa5e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions should be lower case so that they aren't confused with constructors/types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also another lower case function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a default backbone that matches the original paper. Or is something else used more often in practice (@theabhirath or @lorenzoh)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the original CNN series (read: VGG, ResNet, Inception, DenseNet) are used very commonly, but that choice should be on the user since the backbone is often domain dependent (not sure why, but I've seen more DenseNets for medical use cases and more Inceptions for autonomous vehicles and the like). So having the default backbone match the paper would be best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inputsize
should probably be passed in asimsize
andinchannels
matching the other conv-based models in Metalhead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call this
flatten_chains
instead because it only flattensChain
.