Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PyCall module to Pythoncall #1418

Closed
wants to merge 2 commits into from
Closed

Updated PyCall module to Pythoncall #1418

wants to merge 2 commits into from

Conversation

tej2612
Copy link

@tej2612 tej2612 commented Apr 29, 2023

PyCall module has been changed and updated to PythonCall along with the related methods.
It provides flexibility of conversion. PythonCall supports far more combinations of types of T and x and can be extended to support more types.
PythonCall uses a separate Conda environment for each Julia environment/project/package and installs Python (and other Python packages) into that. This means that different Julia projects can maintain an isolated set of Python dependencies (including the Python version itself).
PythonCall supports Julia 1.6.1+ and Python 3.7+. PyCall requires numpy to be installed, PythonCall doesn't (it provides the same fast array access through the buffer protocol and array interface).

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyCall is only used in one place in the test suite. Zygote doesn't actually depend on it or use it. This PR should only change that one place in the test suite instead of find-replacing all instances of Base.convert with pyconvert.

@ToucheSir
Copy link
Member

This was fixed by #1485.

@ToucheSir ToucheSir closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants