made it possible to have separate jars - still some issues though #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the bee and moth systems into genetics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it possible to choose to not have botany, extra bees, or extra trees, however I haven't touched separating genetics from extra trees/bees since that one is a bit more complicated, and I also didn't touch design. So for now I've just made the bees and trees require genetics. I also moved the bee and moth breeding system classes and their static instances into Genetics since without extra bees/trees it would cause an illegal state exception for those systems not existing for the bees and butterflies species roots, even though logically it shouldn't be an issue cause forestry by itself already has butterflies and bees.
The separate jars build, but they build as deobsficated, which is not good, and I also noticed that the sub projects make builds, but I didn't just use those cause the non api ones don't include the api, and I don't know how to include from an outside source in those builds without using some gradle plugin to do that. If you have any better suggestions on how to do the building I'm all ears.
As for why I'm doing this now? cause I wanted a way to be able to use this mod in our pack while still only requiring 4 gigs, and the entirety of binnies jumped the ram usage up like a gig when it was added, so as is it wasn't usable.