Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] changed to delivery address and serial number #191

Closed
wants to merge 1 commit into from

Conversation

DBolen1994
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #191 (9e192b9) into 14.0 (fb9d5ba) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             14.0     #191   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files         156      156           
  Lines        4862     4862           
  Branches      895      895           
=======================================
  Hits         3923     3923           
  Misses        729      729           
  Partials      210      210           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9d5ba...9e192b9. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@AaronHForgeFlow
Copy link
Contributor

It is ok to me to add the lot but not removing price. Ok to me to put the delivery address. WDYT @ChrisOForgeFlow ?

@ChrisOForgeFlow
Copy link
Contributor

It is ok to me to add the lot but not removing price. Ok to me to put the delivery address. WDYT @ChrisOForgeFlow ?

I agree with you, you should keep the price in the view and add the other field

@AaronHForgeFlow
Copy link
Contributor

The serial number was added in this PR: #340 so I think the changes here are not needed anymore. Sorry for the late review and just reopen the PR if you still think this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants